Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

album tag counter #887

Draft
wants to merge 5 commits into
base: staging
Choose a base branch
from
Draft

album tag counter #887

wants to merge 5 commits into from

Conversation

ToMaarton
Copy link
Contributor

@ToMaarton ToMaarton commented Oct 14, 2024

A small tag is added to the photo album cover cards, which displays the total number of tags and also the number of photos that have been tagged out of the total amount of photos.

image

The tag does not show up for albums in which none of the photos have been tagged.

The goal is to provide an easy way to check if the photos in the album have been tagged.

@ToMaarton ToMaarton linked an issue Oct 14, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 13.41%. Comparing base (7b79a90) to head (0f81f0d).

Files with missing lines Patch % Lines
app/models/photo-album.js 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging     #887      +/-   ##
===========================================
- Coverage    13.44%   13.41%   -0.03%     
===========================================
  Files          439      439              
  Lines         3110     3115       +5     
===========================================
  Hits           418      418              
- Misses        2692     2697       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ToMaarton ToMaarton marked this pull request as draft October 14, 2024 21:21
@ToMaarton ToMaarton self-assigned this Oct 15, 2024
@ToMaarton ToMaarton linked an issue Oct 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show total album tags on thumbnail Show number of tagged users in photo overview
1 participant